Skip to content

[Forwardport] Fix module uninstall shell command and composer removal w/out regression#18205

Merged
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
mage2pratik:2.3-develop-PR-port-18002
Sep 26, 2018
Merged

[Forwardport] Fix module uninstall shell command and composer removal w/out regression#18205
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
mage2pratik:2.3-develop-PR-port-18002

Conversation

@mage2pratik
Copy link
Contributor

@mage2pratik mage2pratik commented Sep 23, 2018

Original Pull Request

#18002

Description

There is a discrepancy between composer.lock and composer.json when removing a module via bin/magento module:uninstall command. Also, the output is wrong and the guide says it should do otherwise.
The removal option in the code solved the previous issue #5797 , but caused the new issue. The new change solves both.

Fixed Issues (if relevant)

  1. Module uninstall does not work with composer #17780: Module uninstall does not work with composer

Manual testing scenarios

  1. Install Magento with composer (2.2.x) and set it up
  2. Install Sample Datas with bin/magento sampledata:deploy
  3. Complete Sample Data installation: bin/magento setup:upgrade
  4. Remove one package: bin/magento module:uninstall Magento_CmsSampleData

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels Sep 23, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 23, 2018

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Framework/Composer USE ONLY for FRAMEWORK RELATED BUG! E.g If bug occurs with Catalog use just Catalog Release Line: 2.3 labels Sep 23, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Sep 24, 2018
This was referenced Sep 26, 2018
Closed
Closed
@magento-engcom-team magento-engcom-team merged commit fa4289f into magento:2.3-develop Sep 26, 2018
magento-engcom-team pushed a commit that referenced this pull request Sep 26, 2018
ENGCOM-3034: [Forwardport] Fix module uninstall shell command and com…
795db4f 
…poser removal w/out regression #18205
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 26, 2018

Hi @mage2pratik. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rogyar rogyar

Labels

Component: Framework/Composer USE ONLY for FRAMEWORK RELATED BUG! E.g If bug occurs with Catalog use just Catalog Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.1

Development

Successfully merging this pull request may close these issues.

4 participants

@mage2pratik @magento-engcom-team @rogyar @Thundar